From f2745aadc7d0eb02002f667cd72d8536e4f1daf1 Mon Sep 17 00:00:00 2001 From: "David A. Madore" Date: Thu, 22 Apr 2010 02:16:29 +0200 Subject: Various "stylistic" improvements suggested by Joshua Bloch's book. Use @Override annotation. Limit accessibility of fields. Make final what can be. Use complex enums. Don't ignore exceptions. Some more changes on exceptions thrown. --- org/madore/damlengine/TodoAttr.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'org/madore/damlengine/TodoAttr.java') diff --git a/org/madore/damlengine/TodoAttr.java b/org/madore/damlengine/TodoAttr.java index 2e4cfb8..f510cf9 100644 --- a/org/madore/damlengine/TodoAttr.java +++ b/org/madore/damlengine/TodoAttr.java @@ -13,15 +13,15 @@ public abstract class TodoAttr extends TodoItem { TodoItem caller); } - protected static Map damlAttrFactories; + protected final static Map damlAttrFactories; static { damlAttrFactories = new HashMap(); damlAttrFactories.put("xempty", new TodoXemptyAttr.Factory()); } - Attr attr; - Element owner; + protected final Attr attr; + protected final Element owner; public TodoAttr(Attr attr, Element owner, Context ctx, TodoItem caller) { -- cgit v1.2.3