From f2745aadc7d0eb02002f667cd72d8536e4f1daf1 Mon Sep 17 00:00:00 2001 From: "David A. Madore" Date: Thu, 22 Apr 2010 02:16:29 +0200 Subject: Various "stylistic" improvements suggested by Joshua Bloch's book. Use @Override annotation. Limit accessibility of fields. Make final what can be. Use complex enums. Don't ignore exceptions. Some more changes on exceptions thrown. --- org/madore/damlengine/TodoDamlElement.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'org/madore/damlengine/TodoDamlElement.java') diff --git a/org/madore/damlengine/TodoDamlElement.java b/org/madore/damlengine/TodoDamlElement.java index 419e7d3..9885f36 100644 --- a/org/madore/damlengine/TodoDamlElement.java +++ b/org/madore/damlengine/TodoDamlElement.java @@ -4,9 +4,10 @@ import java.util.ArrayList; import java.util.regex.Pattern; import org.w3c.dom.*; -public class TodoDamlElement extends TodoDefaultElement { +public final class TodoDamlElement extends TodoDefaultElement { public static class Factory extends TodoElement.Factory { + @Override public TodoDamlElement newItem(Element node, Context ctx, TodoItem caller) { @@ -20,6 +21,7 @@ public class TodoDamlElement extends TodoDefaultElement { super(node, ctx, caller); } + @Override public void handleNodeOnly() { if ( ! ( caller instanceof DamlEngine.RootTodo ) ) throw new IllegalArgumentException("daml node can only be root node"); -- cgit v1.2.3