From f2745aadc7d0eb02002f667cd72d8536e4f1daf1 Mon Sep 17 00:00:00 2001 From: "David A. Madore" Date: Thu, 22 Apr 2010 02:16:29 +0200 Subject: Various "stylistic" improvements suggested by Joshua Bloch's book. Use @Override annotation. Limit accessibility of fields. Make final what can be. Use complex enums. Don't ignore exceptions. Some more changes on exceptions thrown. --- org/madore/damlengine/TodoDeque.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'org/madore/damlengine/TodoDeque.java') diff --git a/org/madore/damlengine/TodoDeque.java b/org/madore/damlengine/TodoDeque.java index 4cb1d38..3970938 100644 --- a/org/madore/damlengine/TodoDeque.java +++ b/org/madore/damlengine/TodoDeque.java @@ -5,31 +5,31 @@ import java.util.LinkedList; public final class TodoDeque { - private LinkedList deque; + protected final LinkedList deque; public TodoDeque() { deque = new LinkedList(); } public void registerAtEnd(TodoItem it) { - it.ownerDeque = this; + it.setOwnerDeque(this); deque.addLast(it); } public void registerAtEnd(Collection them) { for ( TodoItem it : them ) - it.ownerDeque = this; + it.setOwnerDeque(this); deque.addAll(them); } public void registerAtStart(TodoItem it) { - it.ownerDeque = this; + it.setOwnerDeque(this); deque.addFirst(it); } public void registerAtStart(Collection them) { for ( TodoItem it : them ) - it.ownerDeque = this; + it.setOwnerDeque(this); deque.addAll(0, them); } @@ -40,7 +40,7 @@ public final class TodoDeque { public boolean dispatchOne() { TodoItem it = removeNext(); if ( it != null ) { - assert(it.ownerDeque == this); + assert(it.getOwnerDeque() == this); it.handle(); return true; } else -- cgit v1.2.3