From f2745aadc7d0eb02002f667cd72d8536e4f1daf1 Mon Sep 17 00:00:00 2001 From: "David A. Madore" Date: Thu, 22 Apr 2010 02:16:29 +0200 Subject: Various "stylistic" improvements suggested by Joshua Bloch's book. Use @Override annotation. Limit accessibility of fields. Make final what can be. Use complex enums. Don't ignore exceptions. Some more changes on exceptions thrown. --- org/madore/damlengine/TodoElement.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'org/madore/damlengine/TodoElement.java') diff --git a/org/madore/damlengine/TodoElement.java b/org/madore/damlengine/TodoElement.java index a871968..4f5d3ab 100644 --- a/org/madore/damlengine/TodoElement.java +++ b/org/madore/damlengine/TodoElement.java @@ -12,8 +12,8 @@ public abstract class TodoElement extends TodoItem { TodoItem caller); } - protected static Map damlFactories; - protected static Factory damlDefaultFactory; + protected final static Map damlFactories; + protected final static Factory damlDefaultFactory; static { damlFactories = new HashMap(); @@ -22,7 +22,7 @@ public abstract class TodoElement extends TodoItem { damlFactories.put("body", new TodoBodyElement.Factory()); } - Element node; + protected final Element node; public TodoElement(Element node, Context ctx, -- cgit v1.2.3