summaryrefslogtreecommitdiffstats
path: root/org/madore/damlengine/LangHelper.java
diff options
context:
space:
mode:
authorDavid A. Madore <david+git@madore.org>2010-04-22 02:16:29 +0200
committerDavid A. Madore <david+git@madore.org>2010-04-22 02:16:29 +0200
commitf2745aadc7d0eb02002f667cd72d8536e4f1daf1 (patch)
treeab03ed4bed1c1cbe9568b3a9f24db15639e41b8d /org/madore/damlengine/LangHelper.java
parent88ef0fa3b0f0ec58cff7d819f9447064be9b6fad (diff)
downloaddamlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.gz
damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.bz2
damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.zip
Various "stylistic" improvements suggested by Joshua Bloch's book.
Use @Override annotation. Limit accessibility of fields. Make final what can be. Use complex enums. Don't ignore exceptions. Some more changes on exceptions thrown.
Diffstat (limited to 'org/madore/damlengine/LangHelper.java')
-rw-r--r--org/madore/damlengine/LangHelper.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/org/madore/damlengine/LangHelper.java b/org/madore/damlengine/LangHelper.java
index c1d736c..a94f5be 100644
--- a/org/madore/damlengine/LangHelper.java
+++ b/org/madore/damlengine/LangHelper.java
@@ -24,7 +24,7 @@ public class LangHelper {
public static void setLangNorec(Element node, String lang) {
if ( lang == null )
- throw new IllegalArgumentException("lang is null in setLangNorec");
+ throw new NullPointerException("lang is null in setLangNorec");
node.setAttributeNS(DamlEngine.XML_NS, LANG, lang);
}
@@ -46,7 +46,7 @@ public class LangHelper {
public static void setLangRec(Element node, String lang) {
if ( lang == null )
- throw new IllegalArgumentException("lang is null in setLangRec");
+ throw new NullPointerException("lang is null in setLangRec");
String parentLang = getLangRec(node.getParentNode());
if ( lang.equals(parentLang) )
unsetLangNorec(node);