diff options
author | David A. Madore <david+git@madore.org> | 2010-04-22 02:16:29 +0200 |
---|---|---|
committer | David A. Madore <david+git@madore.org> | 2010-04-22 02:16:29 +0200 |
commit | f2745aadc7d0eb02002f667cd72d8536e4f1daf1 (patch) | |
tree | ab03ed4bed1c1cbe9568b3a9f24db15639e41b8d /org/madore/damlengine/TodoItem.java | |
parent | 88ef0fa3b0f0ec58cff7d819f9447064be9b6fad (diff) | |
download | damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.gz damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.bz2 damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.zip |
Various "stylistic" improvements suggested by Joshua Bloch's book.
Use @Override annotation. Limit accessibility of fields. Make final
what can be. Use complex enums. Don't ignore exceptions. Some more
changes on exceptions thrown.
Diffstat (limited to 'org/madore/damlengine/TodoItem.java')
-rw-r--r-- | org/madore/damlengine/TodoItem.java | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/org/madore/damlengine/TodoItem.java b/org/madore/damlengine/TodoItem.java index 2c4bfd9..078713c 100644 --- a/org/madore/damlengine/TodoItem.java +++ b/org/madore/damlengine/TodoItem.java @@ -2,15 +2,25 @@ package org.madore.damlengine; public abstract class TodoItem { - public TodoDeque ownerDeque; - public Context ctx; - public TodoItem caller; + protected TodoDeque ownerDeque; + protected final Context ctx; + protected final TodoItem caller; public TodoItem(Context ctx, TodoItem caller) { this.ctx = ctx; this.caller = caller; } + public final TodoDeque getOwnerDeque() { + return this.ownerDeque; + } + + public final void setOwnerDeque(TodoDeque ownerDeque) { + if ( this.ownerDeque != null ) + throw new IllegalStateException("item already owned by a deque"); + this.ownerDeque = ownerDeque; + } + public abstract void handle(); } |