diff options
author | David A. Madore <david+git@madore.org> | 2010-04-22 02:16:29 +0200 |
---|---|---|
committer | David A. Madore <david+git@madore.org> | 2010-04-22 02:16:29 +0200 |
commit | f2745aadc7d0eb02002f667cd72d8536e4f1daf1 (patch) | |
tree | ab03ed4bed1c1cbe9568b3a9f24db15639e41b8d /org/madore/damlengine/TodoAttr.java | |
parent | 88ef0fa3b0f0ec58cff7d819f9447064be9b6fad (diff) | |
download | damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.gz damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.bz2 damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.zip |
Various "stylistic" improvements suggested by Joshua Bloch's book.
Use @Override annotation. Limit accessibility of fields. Make final
what can be. Use complex enums. Don't ignore exceptions. Some more
changes on exceptions thrown.
Diffstat (limited to 'org/madore/damlengine/TodoAttr.java')
-rw-r--r-- | org/madore/damlengine/TodoAttr.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/org/madore/damlengine/TodoAttr.java b/org/madore/damlengine/TodoAttr.java index 2e4cfb8..f510cf9 100644 --- a/org/madore/damlengine/TodoAttr.java +++ b/org/madore/damlengine/TodoAttr.java @@ -13,15 +13,15 @@ public abstract class TodoAttr extends TodoItem { TodoItem caller); } - protected static Map<String,Factory> damlAttrFactories; + protected final static Map<String,Factory> damlAttrFactories; static { damlAttrFactories = new HashMap<String,Factory>(); damlAttrFactories.put("xempty", new TodoXemptyAttr.Factory()); } - Attr attr; - Element owner; + protected final Attr attr; + protected final Element owner; public TodoAttr(Attr attr, Element owner, Context ctx, TodoItem caller) { |