summaryrefslogtreecommitdiffstats
path: root/org/madore/damlengine/TodoDamlElement.java
diff options
context:
space:
mode:
authorDavid A. Madore <david+git@madore.org>2010-04-22 02:16:29 +0200
committerDavid A. Madore <david+git@madore.org>2010-04-22 02:16:29 +0200
commitf2745aadc7d0eb02002f667cd72d8536e4f1daf1 (patch)
treeab03ed4bed1c1cbe9568b3a9f24db15639e41b8d /org/madore/damlengine/TodoDamlElement.java
parent88ef0fa3b0f0ec58cff7d819f9447064be9b6fad (diff)
downloaddamlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.gz
damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.bz2
damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.zip
Various "stylistic" improvements suggested by Joshua Bloch's book.
Use @Override annotation. Limit accessibility of fields. Make final what can be. Use complex enums. Don't ignore exceptions. Some more changes on exceptions thrown.
Diffstat (limited to 'org/madore/damlengine/TodoDamlElement.java')
-rw-r--r--org/madore/damlengine/TodoDamlElement.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/org/madore/damlengine/TodoDamlElement.java b/org/madore/damlengine/TodoDamlElement.java
index 419e7d3..9885f36 100644
--- a/org/madore/damlengine/TodoDamlElement.java
+++ b/org/madore/damlengine/TodoDamlElement.java
@@ -4,9 +4,10 @@ import java.util.ArrayList;
import java.util.regex.Pattern;
import org.w3c.dom.*;
-public class TodoDamlElement extends TodoDefaultElement {
+public final class TodoDamlElement extends TodoDefaultElement {
public static class Factory extends TodoElement.Factory {
+ @Override
public TodoDamlElement newItem(Element node,
Context ctx,
TodoItem caller) {
@@ -20,6 +21,7 @@ public class TodoDamlElement extends TodoDefaultElement {
super(node, ctx, caller);
}
+ @Override
public void handleNodeOnly() {
if ( ! ( caller instanceof DamlEngine.RootTodo ) )
throw new IllegalArgumentException("daml node can only be root node");