summaryrefslogtreecommitdiffstats
path: root/org/madore/damlengine/TodoDeque.java
diff options
context:
space:
mode:
authorDavid A. Madore <david+git@madore.org>2010-04-22 02:16:29 +0200
committerDavid A. Madore <david+git@madore.org>2010-04-22 02:16:29 +0200
commitf2745aadc7d0eb02002f667cd72d8536e4f1daf1 (patch)
treeab03ed4bed1c1cbe9568b3a9f24db15639e41b8d /org/madore/damlengine/TodoDeque.java
parent88ef0fa3b0f0ec58cff7d819f9447064be9b6fad (diff)
downloaddamlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.gz
damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.bz2
damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.zip
Various "stylistic" improvements suggested by Joshua Bloch's book.
Use @Override annotation. Limit accessibility of fields. Make final what can be. Use complex enums. Don't ignore exceptions. Some more changes on exceptions thrown.
Diffstat (limited to 'org/madore/damlengine/TodoDeque.java')
-rw-r--r--org/madore/damlengine/TodoDeque.java12
1 files changed, 6 insertions, 6 deletions
diff --git a/org/madore/damlengine/TodoDeque.java b/org/madore/damlengine/TodoDeque.java
index 4cb1d38..3970938 100644
--- a/org/madore/damlengine/TodoDeque.java
+++ b/org/madore/damlengine/TodoDeque.java
@@ -5,31 +5,31 @@ import java.util.LinkedList;
public final class TodoDeque {
- private LinkedList<TodoItem> deque;
+ protected final LinkedList<TodoItem> deque;
public TodoDeque() {
deque = new LinkedList<TodoItem>();
}
public void registerAtEnd(TodoItem it) {
- it.ownerDeque = this;
+ it.setOwnerDeque(this);
deque.addLast(it);
}
public void registerAtEnd(Collection<? extends TodoItem> them) {
for ( TodoItem it : them )
- it.ownerDeque = this;
+ it.setOwnerDeque(this);
deque.addAll(them);
}
public void registerAtStart(TodoItem it) {
- it.ownerDeque = this;
+ it.setOwnerDeque(this);
deque.addFirst(it);
}
public void registerAtStart(Collection<? extends TodoItem> them) {
for ( TodoItem it : them )
- it.ownerDeque = this;
+ it.setOwnerDeque(this);
deque.addAll(0, them);
}
@@ -40,7 +40,7 @@ public final class TodoDeque {
public boolean dispatchOne() {
TodoItem it = removeNext();
if ( it != null ) {
- assert(it.ownerDeque == this);
+ assert(it.getOwnerDeque() == this);
it.handle();
return true;
} else