summaryrefslogtreecommitdiffstats
path: root/org/madore/damlengine/TodoElement.java
diff options
context:
space:
mode:
authorDavid A. Madore <david+git@madore.org>2010-04-22 02:16:29 +0200
committerDavid A. Madore <david+git@madore.org>2010-04-22 02:16:29 +0200
commitf2745aadc7d0eb02002f667cd72d8536e4f1daf1 (patch)
treeab03ed4bed1c1cbe9568b3a9f24db15639e41b8d /org/madore/damlengine/TodoElement.java
parent88ef0fa3b0f0ec58cff7d819f9447064be9b6fad (diff)
downloaddamlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.gz
damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.tar.bz2
damlengine-f2745aadc7d0eb02002f667cd72d8536e4f1daf1.zip
Various "stylistic" improvements suggested by Joshua Bloch's book.
Use @Override annotation. Limit accessibility of fields. Make final what can be. Use complex enums. Don't ignore exceptions. Some more changes on exceptions thrown.
Diffstat (limited to 'org/madore/damlengine/TodoElement.java')
-rw-r--r--org/madore/damlengine/TodoElement.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/org/madore/damlengine/TodoElement.java b/org/madore/damlengine/TodoElement.java
index a871968..4f5d3ab 100644
--- a/org/madore/damlengine/TodoElement.java
+++ b/org/madore/damlengine/TodoElement.java
@@ -12,8 +12,8 @@ public abstract class TodoElement extends TodoItem {
TodoItem caller);
}
- protected static Map<String,Factory> damlFactories;
- protected static Factory damlDefaultFactory;
+ protected final static Map<String,Factory> damlFactories;
+ protected final static Factory damlDefaultFactory;
static {
damlFactories = new HashMap<String,Factory>();
@@ -22,7 +22,7 @@ public abstract class TodoElement extends TodoItem {
damlFactories.put("body", new TodoBodyElement.Factory());
}
- Element node;
+ protected final Element node;
public TodoElement(Element node,
Context ctx,